Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mlocati as a new maintainer #603

Closed
KorvinSzanto opened this issue Aug 7, 2018 · 9 comments
Closed

Add Mlocati as a new maintainer #603

KorvinSzanto opened this issue Aug 7, 2018 · 9 comments

Comments

@KorvinSzanto
Copy link

Semi-recently, there has been concern over whether this project is still alive: #521 and we've been discussing potentially forking in order to get the security / functionality fixes we need merged. Instead of doing that, I'd like to nominate @mlocati to be included as a maintainer of Imagine.

If you take a look at @mlocati's github account you'll see that he is an open source veteran and a consistent contributor to all sorts of projects including this one. He has several pull requests open at the moment:

and so he has demonstrated a deep understanding of how this library functions, at least in-so-far as these fixes / changes have required. I'd argue that @mlocati is the ideal addition to the maintainer team and will help keep Imagine alive and kicking into the future.

@avalanche123
Copy link
Collaborator

this sounds good to me, I'll let @romainneutron, @burzum, @thePanz or @robfrawley object, if I don't hear objections before then, I'll add @mlocati as a contributor to the repository early next week

@avalanche123
Copy link
Collaborator

done

@mlocati
Copy link
Collaborator

mlocati commented Aug 16, 2018

@avalanche123 Thank you.

I've just a couple of questions:

  • about making decisions about something: should I first ask the other maintainers?
  • should the master branch point to the latest release?

@avalanche123
Copy link
Collaborator

Always a good idea to ask for feedback before making a decision, but set a time cap on it, this way all interested parties have a time to respond and you can make progress if that doesn’t happen. Master is the stable branch, some times it matches the latest a release, usually it is a bit ahead

@mlocati
Copy link
Collaborator

mlocati commented Aug 16, 2018

Always a good idea to ask for feedback before making a decision, but set a time cap on it, this way all interested parties have a time to respond and you can make progress if that doesn’t happen.

👍

Master is the stable branch, some times it matches the latest a release, usually it is a bit ahead

So, at the moment master needs to be fast-forwarded, right? It's still at a commit of 2014-08-26, whereas last version (which should be considered stable) is dated 2017-05-16...

@mlocati
Copy link
Collaborator

mlocati commented Aug 17, 2018

Always a good idea to ask for feedback before making a decision, but set a time cap on it, this way all interested parties have a time to respond and you can make progress if that doesn’t happen.

I'll wait 3/4 days before merging my own new pull requests (if they are not just decorative ones).

About existing pull requests: if they don't have any kind of downvote from any of the people that have write access (@avalanche123, @burzum, @jmikola, @robfrawley, @romainneutron, @thePanz) I'll merge them (of course, if they seems ok to me 😉).

@avalanche123
Copy link
Collaborator

Sounds good to me, thanks for the heads up!

@mlocati
Copy link
Collaborator

mlocati commented Aug 20, 2018

@avalanche123 For #614 I'd need #614 (comment)

@mlocati
Copy link
Collaborator

mlocati commented Aug 24, 2018

@avalanche123 how's the process to publish the docs and API to imagine.readthedocs.io ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants