Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore a phpdoc #84

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Restore a phpdoc #84

merged 1 commit into from
Sep 11, 2024

Conversation

phily245
Copy link
Contributor

@phily245 phily245 commented Sep 9, 2024

v3.0.1 removed this line at 79dff0b#diff-ece1cc9e2cbefb0d1c511f88ab22703e9a402b9ca071df66704f1106c1433ad4L116 (in PR #80), however it isn't covered by a typehint so broke static analysis checks in consuming applications/packages which implement this interface

v3.0.1 removed this line at php-fig@79dff0b#diff-ece1cc9e2cbefb0d1c511f88ab22703e9a402b9ca071df66704f1106c1433ad4L116 (in PR php-fig#80), however it isn't covered by a typehint so broke static analysis checks in consuming applications/packages using this interface
Copy link
Member

@Jean85 Jean85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since arguments cannot be restricted in classes implementing this interface, I'm 👍 with this revert: since you can't change the declaration, silencing the "this is mixed, you should restrict it" should be the way to go.

@Seldaek
Copy link
Collaborator

Seldaek commented Sep 11, 2024

Yup, makes sense.

@Seldaek Seldaek merged commit f16e1d5 into php-fig:master Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants