Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 500.html and 404.html to the app #452

Open
ghost opened this issue Dec 28, 2020 · 2 comments
Open

Add 500.html and 404.html to the app #452

ghost opened this issue Dec 28, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 28, 2020

The nginx.conf of the product uses a 500.html file, which is not in the application right now

@ghost
Copy link
Author

ghost commented Dec 28, 2020

we also have to add it in the existing apps

@ghost ghost changed the title Add 500.html to the app Add 500.html and 404.html to the app Jan 7, 2021
@ghost
Copy link
Author

ghost commented Jan 13, 2021

Please do the following for all products:

  • add 404.html and 500.html of this pr to templates/web/deploy/web (or use the 404.html of the app)
  • change Dockerfile --> add 'COPY ./deploy/web/*.html /usr/share/nginx/html/'
  • change nginx-default.conf as in the pr

Please do the following for all apps:

  • remove src/404.html and remove the import in intialize.XX.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants