Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The nodes' multiaddr address should use P2P protocol instead of IPFS? #88

Open
wqking opened this issue Sep 3, 2019 · 6 comments
Open
Labels
beacon question Further information is requested

Comments

@wqking
Copy link
Contributor

wqking commented Sep 3, 2019

Currently the node addresses look like /ip4/0.0.0.0/tcp/11781/ipfs/12D3KooWSzvx4mxBSGhLzqS3gLp4wrGqivLuNghZadTgH1R1fbVR, which uses IPFS protocol. There are several evidence showing that IPFS is deprecated and it's replaced by P2P.

Evidence 1, in multiformats/go-multiaddr/protocols.go source code,

P_P2P     = 0x01A5
P_IPFS    = 0x01A5 // alias for backwards compatability

Evidence 2, Python version libp2p has nothing about IPFS, and all its example and test code use p2p.

Current problem is that if we continue using IPFS, I'm not sure if py-libp2p can parse the nodes' addresses.

@wqking wqking added question Further information is requested beacon labels Sep 3, 2019
@meyer9
Copy link
Member

meyer9 commented Sep 3, 2019

I believe this is solved by updating the LibP2P version which sort of split the main core repo into a bunch of smaller repos. The core repo is now deprecated.

@wqking
Copy link
Contributor Author

wqking commented Sep 3, 2019

OK. Are you going to upgrade libp2p or let me do it?

@meyer9
Copy link
Member

meyer9 commented Sep 3, 2019

It's a fairly big change. It would probably cause lots of merge conflicts, but you can try to do it. Here's an example deprecated repo: https://github.com/libp2p/go-libp2p-interface-connmgr

@wqking
Copy link
Contributor Author

wqking commented Sep 4, 2019

OK, I will try to do it as long as we decide to do so.

@wqking
Copy link
Contributor Author

wqking commented Sep 4, 2019

Created PR #92

@meyer9
Copy link
Member

meyer9 commented Sep 24, 2019

Closed. I actually wasn't just talking about updating, but it should be fine since I already made the changes on my branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants