Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetValidatorInformation should return error on invalid data #86

Open
wqking opened this issue Aug 30, 2019 · 0 comments
Open

GetValidatorInformation should return error on invalid data #86

wqking opened this issue Aug 30, 2019 · 0 comments
Labels
beacon bug Something isn't working

Comments

@wqking
Copy link
Contributor

wqking commented Aug 30, 2019

Reproduce:

  1. Create a MempoolRequest.
  2. Set MempoolRequest.LastBlockHash to random hash.
  3. Call a Beacon node's GetValidatorInformation with the request.

The Beacon node will return success.
Expect: Beacon should report error because the request type is wrong (it should be GetValidatorRequest, but here is MempoolRequest).
This can be reproduced in Python since Python is dynamic type.

@wqking wqking added bug Something isn't working beacon labels Aug 30, 2019
@meyer9 meyer9 changed the title Beacon RPC bug - GetValidatorInformation should return error on invalid data GetValidatorInformation should return error on invalid data Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant