Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Iterator-like style for shrink implementation #243

Closed
vlsi opened this issue Sep 18, 2019 · 2 comments
Closed

Support Iterator-like style for shrink implementation #243

vlsi opened this issue Sep 18, 2019 · 2 comments

Comments

@vlsi
Copy link
Contributor

vlsi commented Sep 18, 2019

Currently shrink causes lots of objects to be created because doShrink should return List.

It guess it would be better if shrinks could be added iteratively, so the verifier could pick objects and verify them. If property still fails, it could try shrinking the object that fails.

I guess it would produce more targeted results while current API does not make it clear how many shrink results should be produced.

@pholser
Copy link
Owner

pholser commented Oct 7, 2019

@visi Sounds reasonable -- I'll investigate.

@vlsi
Copy link
Contributor Author

vlsi commented Oct 7, 2019

This duplicates #220

@vlsi vlsi closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants