Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting blob binaryType for WebSocket is becoming crucial #538

Closed
apitaru opened this issue Aug 19, 2015 · 2 comments
Closed

Supporting blob binaryType for WebSocket is becoming crucial #538

apitaru opened this issue Aug 19, 2015 · 2 comments

Comments

@apitaru
Copy link

apitaru commented Aug 19, 2015

I think it is becoming crucial to support the blob binaryType in Ejecta's WebSocket. As far as I can tell both react-native(1) and nodejs(2) do not support arraybuffer.

Being able to interface properly with these very popular libraries would be wonderful for Ejecta.

(1) facebook/react-native#1829
(2) websockets/ws#441

@phoboslab
Copy link
Owner

React Native doesn't support Blobs either. Blobs are not a part of JSC, but of WebKit. Typed Arrays are at least supported directly in JSC, but there's still no API to deal with them in C land. nodejs/ws is able to send and receive binary data (binary flag).

Ejecta doesn't care if the WebSocket Server sends and receives binary data as Blobs or ArrayBuffers, because it's just binary data. The Server can do whatever it wants with it. So if the server is not able to handle binary data, it's the server's problem.

Also see facebook/react-native#1424
And this JSC Bug https://bugs.webkit.org/show_bug.cgi?id=120112

@apitaru
Copy link
Author

apitaru commented Aug 19, 2015

Thanks for the detailed response. Seems you're a step ahead of me here : )
I'll take a closer look at it all. Closing this issue. Thanks again!

@apitaru apitaru closed this as completed Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants