Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildalyze removes alias information in result since v 7 #291

Closed
dupdob opened this issue Nov 1, 2024 · 5 comments
Closed

Buildalyze removes alias information in result since v 7 #291

dupdob opened this issue Nov 1, 2024 · 5 comments
Labels
New Feature New Feature

Comments

@dupdob
Copy link
Contributor

dupdob commented Nov 1, 2024

Assembly aliases were available in previous Buildalyzer's versions. Alias information are no longer available since V7.
In early version, aliased assemblies appeared as alias=assembly references. Since V7, the alias= part has disappeared.

This impacts Stryker as it is no longer able to build project using assembly aliases.
We did implement a workaround using Packages information, but this works only when AssemblyName==PackageName and it does not support project reference aliases at all.
I do not think reverting to previous behavior is a good idea, I propose aliases information to be available as map matching assembly pathname to their alias(es).

I am willing to work on a PR to implement this.

@Corniel
Copy link
Contributor

Corniel commented Nov 1, 2024

Can you provide an example project that reproduces this issue, so that we can start from there?

@dupdob dupdob changed the title Buildalyze removes alias information in result sinv 7 Buildalyze removes alias information in result since v 7 Nov 2, 2024
@dupdob
Copy link
Contributor Author

dupdob commented Nov 2, 2024

Here is a solution where the test project refers to the production project via an alias (aliased project reference) and uses xunit attributes via an alias (aliased package reference).
Note: the test project has to reference some xunit internal dependencies explicitly so they can be aliased.

AliasesDemo.zip

@dupdob
Copy link
Contributor Author

dupdob commented Nov 8, 2024

do you need anything else ?
do you wish me to offer a PR for this ?

@Corniel
Copy link
Contributor

Corniel commented Nov 8, 2024

A PR would also be fine. @phmonte did not respond yet, which worries me a bit. I've some PR's open as well, and as he is the (new) owner of the repo, I can not release nor merge anything without his interference. :(

@phmonte
Copy link
Owner

phmonte commented Nov 8, 2024

I'll see the PRs this weekend, I'll try today.
@Corniel @dupdob

@phmonte phmonte added the New Feature New Feature label Nov 12, 2024
@dupdob dupdob closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature New Feature
Projects
None yet
Development

No branches or pull requests

3 participants