Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectReferences could be duplicated, which ends up with ThrowArgumentItemNullOrDuplicateException #203

Closed
Mingxue008 opened this issue Mar 9, 2022 · 4 comments
Labels
⚠ Bug Something isn't working as expected

Comments

@Mingxue008
Copy link
Contributor

Buildalyzer is only parsing the csproj files, and doesn't ensure that ProjectReferences to be distinct when accessed by users. After users get their AnalyseResult and try to add that result back into an AdhocWorkspace, which will call Roslyn ProjectInfo.Create() API and trigger ThrowArgumentItemNullOrDuplicateException by Roslyn default behavior. We would expect ProjectReferences to be distinct even users somehow edit their csproj files and accidently duplicated them.

@daveaglick daveaglick added the ⚠ Bug Something isn't working as expected label Mar 11, 2022
@daveaglick
Copy link
Collaborator

Thanks a bunch for taking the lead on getting this fixed @Mingxue008! Resolved in #204.

@Mingxue008
Copy link
Contributor Author

@daveaglick any update on the release of Buidalyzer?

@daveaglick
Copy link
Collaborator

@Mingxue008 I actually totally forget this wasn't released yet! Thanks for the reminder, pushing the release button now.

@Mingxue008
Copy link
Contributor Author

Thanks for the release, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

2 participants