Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan to migrate this package to Laminas ? #15

Closed
vrkansagara opened this issue Feb 8, 2020 · 7 comments · Fixed by #21
Closed

Any plan to migrate this package to Laminas ? #15

vrkansagara opened this issue Feb 8, 2020 · 7 comments · Fixed by #21

Comments

@vrkansagara
Copy link
Contributor

hello, @weierophinney. I would appreciate it if you can migrate this package as this package provide me some use case for static site generator kind of concept and this helps to keepLaminas is my first priority for development.

@vrkansagara
Copy link
Contributor Author

Hello @weierophinney , I would more appreciative if you can migrate this package to Laminas. As I tried to migrate this package but somehow I can't, Awaiting for your response and many thanks in advance.

@vrkansagara
Copy link
Contributor Author

Hello @weierophinney I don't wanted to bother you but is any plan to migrate this package to Laminas current version?

@rieschl
Copy link
Contributor

rieschl commented Oct 5, 2020

At first glance, at least the following steps have to be done to be usable in a up-to-date laminas-mvc project:

  • bump to PHP 7.x. Probably 7.3 because of PHPUnit 9.3 (or 7.4 if it's not too much work to use typed properties). The MVC skeleton v1.0.0 requires PHP 7.3 so that's probably a reasonable choice
  • upgrade to latest laminas packages

While at it,

  • add a proper LICENSE to repo and composer.json
  • remove custom autoloaders

Is that okay? Probably pretty much the same has to be done in PhlyCommon.

Are you okay with that @weierophinney ?

@weierophinney
Copy link
Contributor

@rieschl Yep, sounds good. I'll add the Hacktoberfest info to PhlyCommon as well; ping me on Slack or tag me in a comment so I see the issues/pull requests.

@vrkansagara
Copy link
Contributor Author

vrkansagara commented Oct 5, 2020

@rieschl I have done bellow task

Ping to @weierophinney

@vrkansagara
Copy link
Contributor Author

@rieschl @weierophinney #19 Is added for symfony-cli for command runner.

@vrkansagara
Copy link
Contributor Author

@weierophinney Ping for open PR.

@weierophinney weierophinney added this to the 2.0.0 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants