Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle windows that are partially off-screen #3

Closed
phisch opened this issue Apr 29, 2019 · 0 comments
Closed

handle windows that are partially off-screen #3

phisch opened this issue Apr 29, 2019 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@phisch
Copy link
Owner

phisch commented Apr 29, 2019

Currently, when a window or geometry is partially outside the root-window, the recording fails without and useful information.

If the area to record is completely outside the root-window, giph should log_error with a proper error message.
Otherwise, it should record the intersecting rectangle between the rectangle to record and the root-window.

@phisch phisch added this to the 1.0 milestone Apr 30, 2019
@phisch phisch added the bug Something isn't working label Apr 30, 2019
@phisch phisch self-assigned this Apr 30, 2019
@phisch phisch closed this as completed in cc1af4c Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant