Error: Invalid format '├── https://github.com/sponsors/broofa' #237

sernaferna · 2024-02-05T15:51:10Z

Getting the error listed above at the tail end of execution. The entire job seems to be running successfully (i.e. there is a message that says "✔ success Version bumped!"), but then there is an error about being unable to process file command 'output' successfully.

Full log:

process.env.GITHUB_WORKSPACE /home/runner/work/<appname>/<appname>/apps/<msname>
tagPrefix: 
tagSuffix: 
commit messages: [
  'force build\nundefined',
  'Merge pull request #1348 from sernaferna/bnd\n\nforce build\nundefined'
]
config words: {
  majorWords: [ 'MAJOR' ],
  minorWords: [ 'MINOR' ],
  patchWords: null,
  preReleaseWords: [ 'pre-alpha', 'pre-beta', 'pre-rc' ]
}
version action after first waterfall: patch
version action after final decision: patch
runInWorkspace | command: git args: [ 'config', 'user.name', '"Automated Version Bump"' ]
runInWorkspace | command: git args: [
  'config',
  'user.email',
  '"[email protected]"'
]
currentBranch: main
runInWorkspace | command: npm args: [
  'version',
  '--allow-same-version=true',
  '--git-tag-version=false',
  '6.1.5'
]
current 1: 6.1.5 / version: patch
newVersion 1:   run `npm fund` for details
runInWorkspace | command: git args: [
  'commit',
  '-a',
  '-m',
  'ci: version bump to   run `npm fund` for details'
]
runInWorkspace | command: git args: [ 'checkout', 'main' ]
runInWorkspace | command: npm args: [
  'version',
  '--allow-same-version=true',
  '--git-tag-version=false',
  '6.1.5'
]
current 2: 6.1.5 / version: patch
execute npm version now with the new version: patch
newVersion 2:   run `npm fund` for details
newVersion after merging tagPrefix+newVersion+tagSuffix:   run `npm fund` for details
runInWorkspace | command: sh args: [
  '-c',
  'echo "newTag=  run `npm fund` for details" >> $GITHUB_OUTPUT'
]
runInWorkspace | command: git args: [
  'commit',
  '-a',
  '-m',
  'ci: version bump to   run `npm fund` for details'
]
git commit failed because you are using "actions/checkout@v2" or later; but that doesnt matter because you dont need that git commit, thats only for "actions/checkout@v1"
runInWorkspace | command: git args: [
  'push',
  '***github.com/sernaferna/<appname>.git'
]
✔  success   Version bumped!
##[error]Unable to process file command 'output' successfully.
##[error]Invalid format '├── https://github.com/sponsors/broofa'

There is an error about a git commit failing, too, but I don't think that's causing the problem -- I could be wrong.

This is for a smaller microservice within a larger monorepo; the relevant section of the YAML is:

  bump-versions:
    needs: paths-filter
    name: Bump version numbers
    runs-on: ubuntu-latest

    steps:
      - name: Checkout source code
        uses: actions/checkout@v4
        with:
          ref: ${{ github.ref }}

      - name: Bump version for <msname>
        uses: phips28/gh-action-bump-version@master
        if: ${{ needs.paths-filter.outputs.msname == 'true' }}
        with:
          target-branch: 'main'
          skip-tag: 'true'
          major-wording: 'MAJOR'
          minor-wording: 'MINOR'
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          PACKAGEJSON_DIR: 'apps/msname'
          GITHUB_REF: ${{ github.ref}}

      - name: Bump version for Workspace
        uses: phips28/gh-action-bump-version@master
        with:
          target-branch: 'main'
          major-wording: 'MAJOR'
          minor-wording: 'MINOR'
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
          GITHUB_REF: ${{ github.ref}}

The text was updated successfully, but these errors were encountered:

whiplashwebb · 2024-02-05T18:08:08Z

+1 Seeing the same issue. I've locked the version on all the flows where i use this action like this:

        uses: "phips28/[email protected]"

and got back on track.

mbret · 2024-02-20T21:57:00Z

I have the same kind of issue but with mui

monorepo as well btw. Using a fixed version did not fix my issue.

mbret · 2024-02-21T08:55:04Z

Okay so it seems that using 10.1.1 works but not v11

phips28 · 2024-02-21T08:59:16Z

do you see anything obviously broken in this PR? https://github.com/phips28/gh-action-bump-version/pull/232/files

this was the last merge before bumping to v11.

@mattanglin can you help please?

psamusev · 2024-02-21T15:28:39Z

Same issue to me and again using yarn workspaces

mbret · 2024-02-21T16:28:12Z

The culprit seems to be parseNpmVersionOutput. It does returns an invalid version number I think due to some weirdness in the outpout

mbret · 2024-02-21T16:28:56Z

I mean everything else seems to be just linting

sernaferna · 2024-03-09T21:32:52Z

Not to be "that guy," but is a fix in the works? 🙂 It's been a couple of weeks since the last comment.

I'd love to get up to a version of the action that's on Node 20, but the current version breaks my build pipeline.

phips28 · 2024-03-10T10:18:46Z

@mbret @sernaferna for me the action works properly, so there might be some packages/setup in your repo that breaks that flow.

can you test uses: 'phips28/gh-action-bump-version@fix-237-invalid-format'

I added some logs to check what your repo outputs:

This is my test repo: https://github.com/phips28/test-gh-action-bump-version/actions/runs/8221259292/job/22481416426#step:4:60

And can you share your package.json dependencies so I can reproduce it?

sernaferna · 2024-03-14T13:59:21Z

Sorry for the delay, haven't been in my home office.

This is a monorepo with 8 sub-projects and some of them have a ton of dependencies, but before we go down that path, the logs might be enough on their own because my output looks different from yours. For reference, this is for a monorepo called soulhx and the sub-project is also named soulhx:

[parseNpmVersionOutput] output: soulhx
v13.0.26

up to date in 3s

302 packages are looking for funding
 run `npm fund` for details

[parseNpmVersionOutput] npmVersionStr:   run `npm fund` for details
newVersion 1:   run `npm fund` for details

mbret · 2024-03-14T15:55:11Z

yeah im not sure we need to reproduce, I believe there are some weird characters in some of the repo (mine was mui) which seems to break some code. You can try to add mui to see if you can reproduce. Maybe something related to the "|--"

phips28 · 2024-03-14T19:35:09Z

@sernaferna thx, that log helps a lot, and already shows whats going wrong.

this is the produced output of npm version --git-tag-version=false ${version}

[parseNpmVersionOutput] output: soulhx
v13.0.26

up to date in 3s

302 packages are looking for funding
 run `npm fund` for details

you see its adding all the stuff like up to date, funding stuff...

and then const npmVersionStr = output.trim().split(EOL).pop(); gets the last line of it:

[parseNpmVersionOutput] npmVersionStr:   run `npm fund` for details

and thats not a correct version ofc... we want v13.0.26.

do you have any preversion npm scripts that does a npm install for example? that could be the reason.

phips28 · 2024-03-14T20:16:49Z

can you test again with uses: 'phips28/gh-action-bump-version@turn-off-npm-fund'
this turns off the fund message.

sernaferna · 2024-03-15T15:29:37Z

I'm not doing an npm install anywhere before this script runs; my YAML does the following:

Job to get changed apps (further jobs use this output to only bump/build/deploy changed apps)
1. checkout@v4
2. dorny/paths-filter@v3
Job to Bump versions
1. checkout@v4
2. phips28/gh-action-bump-version
Job to build and deploy App 1
Job to build and deploy App 2
...

As for the new version, it doesn't work with npm workspaces.

npm ERR! code ENOWORKSPACES
npm ERR! This command does not support workspaces.

npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2024-03-15T15_21_29_725Z-debug-0.log
✖  fatal     Error: Command failed: npm config set fund false
npm ERR! code ENOWORKSPACES
npm ERR! This command does not support workspaces.

npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/2024-03-15T15_21_29_725Z-debug-0.log

    at checkExecSyncError (node:child_process:890:11)
    at execSync (node:child_process:962:15)
    at /home/runner/work/_actions/phips28/gh-action-bump-version/turn-off-npm-fund/index.js:201:5
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
✖  fatal     Failed to bump version

phips28 · 2024-03-16T12:21:30Z

@sernaferna can you try again with uses: 'phips28/gh-action-bump-version@turn-off-npm-fund'
I pushed a fix to use runInWorkspace

sernaferna · 2024-03-16T13:11:29Z

Unfortunately it still doesn't work in a workspace. 🙁

Here's a slightly longer version of the log; to make things a little clearer I attempted with an application that doesn't have the same name as the workspace. 🙂 So in this case it's workspace soulhx and application papi.

process.env.GITHUB_WORKSPACE /home/runner/work/soulhx/soulhx/apps/papi
tagPrefix: 
tagSuffix: 
commit messages: [
  'new attempt for bumping\nundefined',
  'Merge pull request #1437 from sernaferna/bump\n' +
    '\n' +
    'new attempt for bumping\n' +
    'undefined'
]
config words: {
  majorWords: [ 'MAJOR' ],
  minorWords: [ 'MINOR' ],
  patchWords: null,
  preReleaseWords: [ 'pre-alpha', 'pre-beta', 'pre-rc' ]
}
version action after first waterfall: patch
version action after final decision: patch
runInWorkspace | command: git args: [ 'config', 'user.name', '"Automated Version Bump"' ]
runInWorkspace | command: git args: [
  'config',
  'user.email',
  '"[email protected]"'
]
currentBranch: main
runInWorkspace | command: npm args: [ 'config', 'set', 'fund', 'false' ]
✖  fatal     npm ERR! code ENOWORKSPACES
npm ERR! This command does not support workspaces.
npm ERR! A complete log of this run can be found in: /home/runner/.npm/_logs/20[24](https://github.com/sernaferna/soulhx/actions/runs/8308005489/job/22737785808#step:5:25)-03-16T13_08_[34](https://github.com/sernaferna/soulhx/actions/runs/8308005489/job/22737785808#step:5:35)_978Z-debug-0.log
npm exited with code 1
✖  fatal     Failed to bump version

phips28 · 2024-03-16T13:57:54Z

ok pushed another change for workspaces, try again

sernaferna · 2024-03-16T19:02:55Z

Works! 🙂

phips28 · 2024-03-16T19:50:53Z

Thats great. Then I will merge later and create a new release

phips28 mentioned this issue Feb 5, 2024

feature: npm version output parsing to allow version hooks #232

Merged

phips28 mentioned this issue Mar 16, 2024

Turn off npm fund #241

Merged

phips28 closed this as completed in #241 Mar 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error: Invalid format '├── https://github.com/sponsors/broofa' #237

Error: Invalid format '├── https://github.com/sponsors/broofa' #237

sernaferna commented Feb 5, 2024

whiplashwebb commented Feb 5, 2024

mbret commented Feb 20, 2024 •

edited

Loading

mbret commented Feb 21, 2024

phips28 commented Feb 21, 2024 •

edited

Loading

psamusev commented Feb 21, 2024

mbret commented Feb 21, 2024

mbret commented Feb 21, 2024

sernaferna commented Mar 9, 2024

phips28 commented Mar 10, 2024 •

edited

Loading

sernaferna commented Mar 14, 2024

mbret commented Mar 14, 2024

phips28 commented Mar 14, 2024

phips28 commented Mar 14, 2024

sernaferna commented Mar 15, 2024

phips28 commented Mar 16, 2024

sernaferna commented Mar 16, 2024 •

edited

Loading

phips28 commented Mar 16, 2024

sernaferna commented Mar 16, 2024

phips28 commented Mar 16, 2024

Error: Invalid format '├── https://github.com/sponsors/broofa' #237

Error: Invalid format '├── https://github.com/sponsors/broofa' #237

Comments

sernaferna commented Feb 5, 2024

whiplashwebb commented Feb 5, 2024

mbret commented Feb 20, 2024 • edited Loading

mbret commented Feb 21, 2024

phips28 commented Feb 21, 2024 • edited Loading

psamusev commented Feb 21, 2024

mbret commented Feb 21, 2024

mbret commented Feb 21, 2024

sernaferna commented Mar 9, 2024

phips28 commented Mar 10, 2024 • edited Loading

sernaferna commented Mar 14, 2024

mbret commented Mar 14, 2024

phips28 commented Mar 14, 2024

phips28 commented Mar 14, 2024

sernaferna commented Mar 15, 2024

phips28 commented Mar 16, 2024

sernaferna commented Mar 16, 2024 • edited Loading

phips28 commented Mar 16, 2024

sernaferna commented Mar 16, 2024

phips28 commented Mar 16, 2024

mbret commented Feb 20, 2024 •

edited

Loading

phips28 commented Feb 21, 2024 •

edited

Loading

phips28 commented Mar 10, 2024 •

edited

Loading

sernaferna commented Mar 16, 2024 •

edited

Loading