Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] existing review request for new PR #58

Closed
aptalca opened this issue Aug 6, 2019 · 1 comment
Closed

[feature request] existing review request for new PR #58

aptalca opened this issue Aug 6, 2019 · 1 comment

Comments

@aptalca
Copy link

aptalca commented Aug 6, 2019

When a PR is opened, the new_pullrequest rules correctly adds it to the correct board.
After that, if a reviewer is added, the added_reviewer rule correctly moves it to the correct board.

However, if a PR is opened with already added reviewers, the above rules don't work properly, where the new_pullrequest rule adds it to the "new PR" board but it never gets moved to the "review necessary" board because the reviewer was added before the PR was added. The added_reviewer rule never triggers.

This also happens if someone opens a new PR and within a few seconds adds a reviewer before the project-bot adds it to the project board.

I guess this request is for conditional rules. For instance, new_pullrequest could be combined with added_reviewer to add it directly to the "review necessary" board if both conditions are fulfilled. If not, it gets added to "new PR" board.

Thanks

@aptalca
Copy link
Author

aptalca commented Aug 6, 2019

Just realized that this may be mitigated by #6 although that PR has been pending for over a year :(

@aptalca aptalca closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant