From 037307deb2cc0d7b3107a404bfe8fffc1bfe0429 Mon Sep 17 00:00:00 2001
From: "peng.liu6@apple.com"
 <peng.liu6@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date: Fri, 2 Oct 2020 20:35:38 +0000
Subject: [PATCH] [Media in GPU Process] Remove requiresTextTrackRepresentation
 in RemoteMediaPlayerState https://bugs.webkit.org/show_bug.cgi?id=217230

Reviewed by Jer Noble.

A Web process can figure out whether the fullscreen/picture-in-picture subtitle
layer (for text track representation) is required by itself, so it does not need
to get the information from the GPU process.

* WebProcess/GPU/media/RemoteMediaPlayerState.h:
(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 Source/WebKit/ChangeLog                           | 15 +++++++++++++++
 .../WebProcess/GPU/media/RemoteMediaPlayerState.h | 10 +---------
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
index 9e7d4f02f3d4e..57d4367e02937 100644
--- a/Source/WebKit/ChangeLog
+++ b/Source/WebKit/ChangeLog
@@ -1,3 +1,18 @@
+2020-10-02  Peng Liu  <peng.liu6@apple.com>
+
+        [Media in GPU Process] Remove requiresTextTrackRepresentation in RemoteMediaPlayerState
+        https://bugs.webkit.org/show_bug.cgi?id=217230
+
+        Reviewed by Jer Noble.
+
+        A Web process can figure out whether the fullscreen/picture-in-picture subtitle
+        layer (for text track representation) is required by itself, so it does not need
+        to get the information from the GPU process.
+
+        * WebProcess/GPU/media/RemoteMediaPlayerState.h:
+        (WebKit::RemoteMediaPlayerState::encode const):
+        (WebKit::RemoteMediaPlayerState::decode):
+
 2020-10-02  Brian Burg  <bburg@apple.com>
 
         [Cocoa] Web Inspector: add an ObjC protocol for extension support
diff --git a/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h b/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h
index 2c91ea93f7d93..c28e87df79dec 100644
--- a/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h
+++ b/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h
@@ -65,7 +65,6 @@ struct RemoteMediaPlayerState {
     bool wirelessVideoPlaybackDisabled { false };
     bool hasSingleSecurityOrigin { false };
     bool didPassCORSAccessCheck { false };
-    bool requiresTextTrackRepresentation { false };
 
     template<class Encoder>
     void encode(Encoder& encoder) const
@@ -100,7 +99,6 @@ struct RemoteMediaPlayerState {
         encoder << wirelessVideoPlaybackDisabled;
         encoder << hasSingleSecurityOrigin;
         encoder << didPassCORSAccessCheck;
-        encoder << requiresTextTrackRepresentation;
     }
 
     template <class Decoder>
@@ -252,11 +250,6 @@ struct RemoteMediaPlayerState {
         if (!didPassCORSAccessCheck)
             return WTF::nullopt;
 
-        Optional<bool> requiresTextTrackRepresentation;
-        decoder >> requiresTextTrackRepresentation;
-        if (!requiresTextTrackRepresentation)
-            return WTF::nullopt;
-
         return {{
             WTFMove(*currentTime),
             WTFMove(*duration),
@@ -287,8 +280,7 @@ struct RemoteMediaPlayerState {
             *hasAvailableVideoFrame,
             *wirelessVideoPlaybackDisabled,
             *hasSingleSecurityOrigin,
-            *didPassCORSAccessCheck,
-            *requiresTextTrackRepresentation,
+            *didPassCORSAccessCheck
         }};
     }