Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

placeOrders not working correctly for some optional fields #49

Closed
Soccerama opened this issue Mar 13, 2021 · 2 comments
Closed

placeOrders not working correctly for some optional fields #49

Soccerama opened this issue Mar 13, 2021 · 2 comments

Comments

@Soccerama
Copy link
Contributor

The current placeOrders function is not working correctly for customerOrderRef and handicap fields. Fix is straightforward and will put in a pull request with updated code.
@Soccerama Soccerama mentioned this issue Mar 13, 2021
Merged
@Soccerama
Copy link
Contributor Author

Soccerama commented Mar 14, 2021 •
edited
Loading

Phill, I think this issue can be closed with the latest pull request #50. Also think issue #19 is resolved - have you had a chance to test the current implementation to confirm that it works?

@phillc73
Copy link
Owner

Thanks. I'll close this one. Haven't check #19. Still on the to do list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillc73 @Soccerama