Skip to content
This repository has been archived by the owner on May 10, 2023. It is now read-only.

Feature Request: Comments #62

Open
diemuzi opened this issue Jun 22, 2014 · 3 comments
Open

Feature Request: Comments #62

diemuzi opened this issue Jun 22, 2014 · 3 comments
Labels

Comments

@diemuzi
Copy link

diemuzi commented Jun 22, 2014

I was curious if it would be possible to include support for table / column comments to be transferred?

If this is already supported, is there anything special I need to do to get those transferred?

@kworr
Copy link
Collaborator

kworr commented Jun 27, 2014

I think this was done at #55. You need to fetch latest sources from the repo to test.

@diemuzi
Copy link
Author

diemuzi commented Jun 27, 2014

Aha, you're right. Tested and it appears it currently does not work. It actually only gets the comments for tables/columns which have no comments.

As a test I create a comment on 1 out of 2 columns listed in a table called a_new_perspective. I then ran the convert tool and had it export the data to a file and upon review of the file I do see a line like this:

COMMENT ON COLUMN a_new_perspective.test1 is '';

Once I removed the comment from the table I can now see this:

COMMENT ON COLUMN a_new_perspective.test1 is '';
COMMENT ON COLUMN a_new_perspective.test2 is '';

I expected to see the following:

COMMENT ON COLUMN a_new_perspective.test2 is 'SammieTest2';

So it does appear that the comments are attempting to be copied over, but only for those without comments. Quite the interesting...

@kworr
Copy link
Collaborator

kworr commented Aug 28, 2014

I just merged #63, can you try that again?

@kworr kworr added the feedback label Aug 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants