Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rework rust installation #426

Merged
merged 4 commits into from
May 29, 2024
Merged

chore: rework rust installation #426

merged 4 commits into from
May 29, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented May 29, 2024

Pull Request

Description of changes

This PR reworks the rust installation for Ubuntu 24.04. Several changes are included:

  • rustup is installed via apt, as it is now part of the 24.04 packages
  • rust is installed with the minimal profile, excluding docs, reducing image size with 700M
  • additional rust tools are installed with cargo-binstall, removing the need for compilation from source

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner May 29, 2024 08:30
Copy link
Contributor

github-actions bot commented May 29, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.06s
✅ DOCKERFILE hadolint 2 0 0.48s
✅ JSON prettier 11 0 0 0.95s
✅ JSON v8r 10 0 4.5s
✅ MARKDOWN markdownlint 8 0 0 1.1s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.3s
✅ REPOSITORY checkov yes no 16.85s
✅ REPOSITORY gitleaks yes no 0.35s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 15.05s
✅ REPOSITORY secretlint yes no 1.6s
✅ REPOSITORY trivy yes no 12.09s
✅ REPOSITORY trivy-sbom yes no 2.54s
✅ REPOSITORY trufflehog yes no 2.65s
✅ SPELL lychee 48 0 2.12s
✅ YAML prettier 19 0 0 1.19s
✅ YAML v8r 19 0 10.94s
✅ YAML yamllint 19 0 0.39s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented May 29, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:b61b79775b32195fcaae6b80a0b5e92021b1d9a3c07c21622fbfebb19d1cff20

OS/Platform Previous Size Current Size Delta
linux/amd64 632.00M 632.12M 124.94K (+0.02%)
linux/arm64 624.80M 624.85M 48.85K (+0.01%)

Copy link
Contributor

github-actions bot commented May 29, 2024

Test Results

 2 files  ±0   2 suites  ±0   51s ⏱️ ±0s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 80051be. ± Comparison against base commit d2903c0.

♻️ This comment has been updated with latest results.

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:986479f79734eb83c91065af2f819842675681bb01112a26ed447f3f937aeb26

OS/Platform Previous Size Current Size Delta
linux/amd64 491.81M 427.01M -64.80M (-13.17%)
linux/arm64 630.31M 566.46M -63.86M (-10.13%)

@rjaegers rjaegers enabled auto-merge May 29, 2024 09:50
@rjaegers rjaegers added this pull request to the merge queue May 29, 2024
Merged via the queue into main with commit 5c919db May 29, 2024
18 checks passed
@rjaegers rjaegers deleted the feature/use-cargo-binstall branch May 29, 2024 11:27
Copy link
Contributor

Pull Request Report (#426)

Static measures

Description Value
Number of added lines 27
Number of deleted lines 28
Number of changed files 5
Number of commits 4
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 3 Hours
Time that was spend on the branch before the PR was created 5.5 Min
Time that was spend on the branch before the PR was merged 3.1 Hours
Time to merge after last review 10.3 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 24.5 Min
Total time spend in last status check run on PR 2.1 Hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants