Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disable spot instances. #655

Closed
npalm opened this issue Mar 9, 2021 · 4 comments
Closed

Support disable spot instances. #655

npalm opened this issue Mar 9, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@npalm
Copy link
Member

npalm commented Mar 9, 2021

The runner module hardcoded the usages of spot usags by setting market option to spot see:

variable "market_options" {
.

Would be better to make it configurable with default spot to support also on demand instances.

See also https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_InstanceMarketOptionsRequest.html

@npalm npalm added enhancement New feature or request good first issue Good for newcomers labels Mar 9, 2021
@dimisjim
Copy link
Contributor

dimisjim commented Mar 9, 2021

@npalm Implemented here: #657

@michaelstepner
Copy link

@npalm @dimisjim Thanks for implementing this feature! It will be super useful in my work, and I'm grateful you're providing this public good.

@michaelstepner
Copy link

Can be closed now that #657 is merged, I think. I just deployed that patch to my production server! (^-^)/ Thanks again.

@npalm
Copy link
Member Author

npalm commented Jul 14, 2021

Spot can be disabled by setting variable market_options

@npalm npalm closed this as completed Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants