fix(multi-runner): Fix runner_additional_security_group_ids #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `runner_additional_security_group_ids` is only set outside the multi_runner_config `coalesce(each.value.runner_config.runner_additional_security_group_ids, var.runner_additional_security_group_ids)` is coalescing an empty list (the default value for `each.value.runner_config.runner_additional_security_group_ids`) with whatever is set outside the multi_runner_config, this always results in the returned value being an empty list: ``` > coalesce([], ["sg-123456"]) tolist([]) ``` Using coalescelist instead returns the first non-empty list: ``` > coalescelist([], ["sg-123456"]) [ "sg-123456", ] ``` And the `try` returns an empty list if both coalesced lists are empty (rather than throwing an error): ``` > try(coalescelist([], []), []) [] ```
GuptaNavdeep1983
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
runner_additional_security_group_idsis only set outside the multi_runner_configcoalesce(each.value.runner_config.runner_additional_security_group_ids, var.runner_additional_security_group_ids)is coalescing an empty list (the default value foreach.value.runner_config.runner_additional_security_group_ids) with whatever is set outside the multi_runner_config, this always results in the returned value being an empty list:Using coalescelist instead returns the first non-empty list:
And the
tryreturns an empty list if both coalesced lists are empty (rather than throwing an error):