Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support AWS 5.x Terraform provider #3315

Merged
merged 7 commits into from
Jun 16, 2023
Merged

feat: Support AWS 5.x Terraform provider #3315

merged 7 commits into from
Jun 16, 2023

Conversation

jakub-pietrzak
Copy link
Contributor

This PR brings support for the AWS provider version 5 as I can not include the module into workspaces that use this version due to constraint (~> 4.0).

I have also performed terraform upgrade of the lock files (not sure if this is needed).

@GuptaNavdeep1983
Copy link
Contributor

@jakub-pietrzak, Thanks for submitting the PR. Can you please fix the broken CI pipelines?

@GuptaNavdeep1983
Copy link
Contributor

@jakub-pietrzak, Thanks for submitting the PR. Can you please fix the broken CI pipelines?

I have resolved few issues originating from examples where we were using a old version of vpc module in examples. With latest version of VPC module, we are not using any module in this repo which is using old version of aws terraform provider.

@jakub-pietrzak
Copy link
Contributor Author

@GuptaNavdeep1983 thank you. Are there any more issues that I could help with?

@GuptaNavdeep1983 GuptaNavdeep1983 merged commit d0e8960 into philips-labs:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants