fix(multi-runner): allow runner_additional_security_group_ids to apply to multi_runner_config #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…individual multi-runner configs
darklab-sh
changed the title
darklab-sh
changed the title
…-aws-github-runner into multi-runner-sg-fix
npalm
changed the title
npalm
reviewed
Apr 28, 2023
npalm
reviewed
May 1, 2023
Co-authored-by: Niek Palm <[email protected]>
npalm
previously approved these changes
May 23, 2023
npalm
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when specifying the runner_additional_security_group_ids input within the multi_runner_config block, it is ignored. It has to be specified outside the multi_runner_config block, which means all runner configs will receive the same additional security groups. In our use-case, we need to specify different security groups for each config.
This PR supports adding the runner_additional_security_group_ids input either inside or outside of the multi_runner_config block. If added outside, the behavior does not change. All runner configs will receive the security groups. If added inside the multi_runner_config block, the specified security group(s) will only be added to the specified runner config.
I've tested all use cases I can think of, ran the pre-commit checks and updated the documentation. Please let me know if anything else is needed.