Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows runner including the VS2019 C++ build tools #1553

Closed
pbronneberg opened this issue Dec 22, 2021 · 4 comments
Closed

Windows runner including the VS2019 C++ build tools #1553

pbronneberg opened this issue Dec 22, 2021 · 4 comments

Comments

@pbronneberg
Copy link

pbronneberg commented Dec 22, 2021

Hi,

I would love to start using the Windows Runners.
So, really happy to see PR #1525 by @maths22!

My toolchain requires Visual C++ (VS2019) on top of this Windows-Core-2019 image.
As far as I know, for Windows it is not so easy to use a bare agent and install dependencies for each build. (or has this improved?)
So, I would like to build an image based on Windows-Core-2019 and add VS2019 build tools & Windows SDKs via chocolatey packages.

Happy to bring this in a PR., but looking for some advise before I start:

  • shall I add another image to enable this? (e.g. windows-core-2019-vs2019) Or does this specific image belong in a separate repo?
  • Are there already ideas on how to support a variety of images? (e.g. ephemeral runners, scaling out from 0 when needed)

Perhaps @ScottGuymer or @npalm will know the answer :)

Thanks!

@ScottGuymer
Copy link
Member

ScottGuymer commented Dec 22, 2021

I would lean towards keeping the agents as simple as possible and bring additional build tools via containers.

Managing agents with all different kinds of dependencies is not really feasible at scale.

The con is that windows images can be large so pull times can start to factor in. There are things we can do to speed things up though.

@npalm
Copy link
Member

npalm commented Dec 23, 2021

The packer examples in this repository are meant as a simple example to get started to buil you rown custom AMI. In this repo I would like to keep them as simple as possible.

@ScottGuymer The windows github action runner does not support docker. Docker is not supported via the orchestrator like you can use for docker or actions. Do you mean to run a trigger a build in docker for windows via a script?

@ScottGuymer
Copy link
Member

ScottGuymer commented Dec 24, 2021

EDIT: on further testing you can't actually do this, it complains at you a lot.

No, I mean using a windows container for a job like this

jobs:
  containerjob:
    runs-on: [self-hosted, windows]    
    container: mcr.microsoft.com/windows/servercore:20H2

    steps:
      - uses: actions/checkout@v1
      - name: build
        run: |
          echo "Hello World from a windows container!"

@ScottGuymer
Copy link
Member

Closing as cusomised AMIs are beyond the scope of this module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants