Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parsing variables to start runner agent #1522

Closed
npalm opened this issue Dec 14, 2021 · 2 comments · Fixed by #1842
Closed

Refactor parsing variables to start runner agent #1522

npalm opened this issue Dec 14, 2021 · 2 comments · Fixed by #1842
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@npalm
Copy link
Member

npalm commented Dec 14, 2021

The way we parse runner parameters is becoming hard to maintain and extend. Some refactoring required.

Review on PR #1374

I think it might be better when working with these command to use a string array and then join then with a space. Rather than having to worry about spaces in all the strings etc.

runnerServiceConfig could be defined as a string array above and you can merge the arrays and join.

Originally posted by @ScottGuymer in #1374 (comment)

@ScottGuymer ScottGuymer added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 2, 2022
@ulich
Copy link
Contributor

ulich commented Mar 10, 2022

I would be happy to pick this up

@npalm
Copy link
Member Author

npalm commented Mar 10, 2022

Great, you help is very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants