Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement webhook endpoint for garo-server #11

Open
marcofranssen opened this issue Feb 25, 2020 · 2 comments
Open

Implement webhook endpoint for garo-server #11

marcofranssen opened this issue Feb 25, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@marcofranssen
Copy link
Member

marcofranssen commented Feb 25, 2020

Garo server needs a /webhook endpoint which can be consumed by github.com

The webhook endpoint should be protected by a configurable secret to prevent abuse of this API.

IP whitelisting can be arranged via a LB / security group

The check_run webhook should enable us to check if a build failed due to no available runner. If this occurs Garo-server needs to track this so the agents can retrieve for which repositories a runner has to be deployed and as well which runs need to be retriggered.

@marcofranssen
Copy link
Member Author

@npalm could you add the involved curl requests to retrieve the run-failure?

@npalm
Copy link
Member

npalm commented Feb 25, 2020

I would suggest we implement a webhook and dispatch event to a command handler for specific events. to start with we only need an event listener for the check_run event.

@marcofranssen marcofranssen added enhancement New feature or request good first issue Good for newcomers labels Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants