Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+Y works only in insert mode at outlook.office.com #4560

Open
wojnilowicz opened this issue Oct 17, 2024 · 3 comments
Open

Ctrl+Y works only in insert mode at outlook.office.com #4560

wojnilowicz opened this issue Oct 17, 2024 · 3 comments

Comments

@wojnilowicz
Copy link

Describe the bug

Focus doesn't switch to the folder pane after pressing Ctrl+y combination in Outlook. A workaround is to first press "i" to switch Vimium to insert mode and then Ctrl+y works as expected. "Excluded URLs and keys" has "https?://outlook.office.com/*" set for the URL and "y" set for the key.

To Reproduce

Steps to reproduce the behavior:

  1. Open your mailbox at https://outlook.office.com
  2. Press Ctrl+y in order to "Navigate to the folder pane"

Browser and Vimium version

Microsoft Edge 129.0.2792.89 on Linux
Vimium 2.1.2

@philg-dev
Copy link

CTRL + Y is bound to the scrollUp action in Vimium by default.

I just realized, that it doesn't seem to be working to exclude mappings with modifier keys like that on a per-site basis via the exclude rules. At least I couldn't figure out a way that works on the fly.

If you don't use the CTRL + Y Vimium binding elsewhere to scroll up (most people probably use k to scroll up anyway) then you can probably fix your problem by unmapping it globally.

For that, you can go to the Vimium Options and add the following to the "Custom key mappings" section:

unmap <c-y>

Don't forget to save the changes. You might also have to reload the affected website in order for the changes to take effect.

@wojnilowicz
Copy link
Author

Your workaround helps indeed. Thank you. Is this still a bug then?

@philg-dev
Copy link

Vimium Keybinds overriding existing shortcuts on a page is the intended behavior. The vimium keybinds "consume" the key event.

This helps prevent unintentionally triggering functions on a webpage that you might not know about, when trying to just use Vimium functions to navigate the page.

So the general approach is to exclude certain keys on webpages that have their own keybindings that are important to you. A pretty common one would probably be on pages with video players (YouTube, Twitch, etc.): those usually have f for fullscreen and m to mute / unmute. Both of those keys are mapped in Vimium by default, so it makes sense to add them to excluded keys for those pages, if you want to be able to use those video-player related shortcuts instead.

Regarding excluded keys that are key combinations with modifier keys (e.g. <c-y>) not working, that might be an oversight, a bug or just an accepted limitation of the exclusion algorithm. Maybe there's even a way to escape such key combinations - I don't know for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants