Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should there be benchmarking tests as part of the test suite? #17

Open
kjetilkjeka opened this issue Apr 28, 2018 · 2 comments
Open

Should there be benchmarking tests as part of the test suite? #17

kjetilkjeka opened this issue Apr 28, 2018 · 2 comments

Comments

@kjetilkjeka
Copy link
Contributor

To keep up with improvements and avoid regressions and being surprised with things as #15

@huwsun have already helped out creating some in #15. If the benchmarking tests is desired, perhaps he can help out some more with this issue.

Is it possible to break CI for terrible benches? Is this desired?
@phil-opp
Copy link
Owner

Adding benchmarks to this repo would be great. Breaking CI for huge regressions would be also ok with me.

@phil-opp phil-opp mentioned this issue Apr 29, 2018
Closed
@imhun imhun mentioned this issue May 2, 2018
Merged
@phil-opp
Copy link
Owner

phil-opp commented May 3, 2018

Benchmarks are now run on travis: https://travis-ci.org/phil-opp/rust-bit-field/jobs/374333150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phil-opp @kjetilkjeka