Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Lookup from Context Menu in Preview #26

Closed
Moonbase59 opened this issue Jul 23, 2021 · 6 comments
Closed

[Feature Request] Lookup from Context Menu in Preview #26

Moonbase59 opened this issue Jul 23, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@Moonbase59
Copy link

The rationale: Many of us use Dataview to show content in lists and tables. These can’t be seen in edit mode, obviously. Would be nice if words could be clicked in preview mode, and a context menu shown with "lookup". Links might present a problem though—didn’t find a way to highlight part of a link (say, a note’s file name).

@phibr0
Copy link
Owner

phibr0 commented Jul 23, 2021

This is certainly possible, but since Obsidian only has a API for Edit Mode, if I would want to create Custom Context Menu Entries for Preview, I would have to override existing functionalities. Something like Copy isn't a big deal, I could easily implement that on my own, but I really dont want to reimplement Entries for all of this:

image

@Moonbase59
Copy link
Author

Yeah, that’s right. Too bad, but we can’t have everything … ;-)

@phibr0 phibr0 added the enhancement New feature or request label Jul 24, 2021
@Moonbase59
Copy link
Author

I’d be fine with closing this for now, or do you want to keep it open?

@phibr0
Copy link
Owner

phibr0 commented Jul 27, 2021

I kinda want to get this working too. I will look whats possible in the next days

@phibr0 phibr0 changed the title Idea for the future: Can it be made working in preview mode? [Feature Request] Lookup from Context Menu in Preview Jul 28, 2021
@phibr0
Copy link
Owner

phibr0 commented Aug 15, 2021

Once you update it should work in Preview!

@phibr0 phibr0 closed this as completed in e00c2b1 Aug 15, 2021
@Moonbase59
Copy link
Author

Now how cool is that! Thanks for implementing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: done
Development

No branches or pull requests

2 participants