Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: timer restart button is darker in toolbox #514

Open
KatieWoe opened this issue Jan 13, 2021 · 6 comments
Open

Safari: timer restart button is darker in toolbox #514

KatieWoe opened this issue Jan 13, 2021 · 6 comments

Comments

@KatieWoe
Copy link
Contributor

Device
MacBook Air and iPad 6th Gen
OS
MacOS 10.15 and iPadOS 14.3
Browser
Safari
Problem Description
For phetsims/qa#580. Does not occur in published.
The restart timer button on the timer is disabled while it is in the toolbox since the timer is at 0. However, in Safari, what that looks like in the box and out of the box is different. In the box, the button is darker. Out of the box, and in other browsers, the button is lighter.
Visuals:
Win 10 Chrome:
buttoncolorwinchrome
On iPad:
Image from iOS (1)
Image from iOS

@samreid
Copy link
Member

samreid commented Jan 15, 2021

I wonder if a filter is getting applied twice?

@samreid
Copy link
Member

samreid commented Jan 19, 2021

@jonathanolson does this seem like it is related to the scenery filters?

@samreid
Copy link
Member

samreid commented Jan 20, 2021

I confirmed this problem is happening on Mac Safari but not Mac Chrome on https://phet-dev.colorado.edu/html/waves-intro/1.1.0-rc.3/phet/waves-intro_all_phet.html. It is also happening on master.

In

const stopwatchNodeIcon = stopwatchNode.rasterized().mutate( { scale: 0.45 } );
the stopwatch is rasterized. If I remove the rasterization step, the problem goes away--this suggests that color filters are incorrect for Safari.

To test this hypothesis, I tried taking a screenshot on Safari. In this screenshot, the top is the live sim and the bottom is the screenshot. Please ignore the yellow highlight:

image

I'll open a scenery issue.

@jonathanolson
Copy link
Contributor

Yes, seems like phetsims/scenery#1142. Is this blocking for this sim (presumably?)

@arouinfar
Copy link
Contributor

In phetsims/scenery#1142 (comment) we decided this is not a blocking issue.

@samreid samreid removed this from the sonify + basic keyboard nav milestone Jan 29, 2021
@samreid
Copy link
Member

samreid commented Jul 4, 2021

On hold until phetsims/scenery#1142 has progress.

@samreid samreid removed their assignment Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants