From d2713a4831b3149ecfe3520740970ec0f8a0b299 Mon Sep 17 00:00:00 2001 From: Chris Malley Date: Wed, 19 Dec 2018 11:24:47 -0700 Subject: [PATCH] promote REVIEW comments to issue, #280, #269 Signed-off-by: Chris Malley --- js/common/view/WaveInterferenceSceneIcons.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/js/common/view/WaveInterferenceSceneIcons.js b/js/common/view/WaveInterferenceSceneIcons.js index bba221ac..619d995f 100644 --- a/js/common/view/WaveInterferenceSceneIcons.js +++ b/js/common/view/WaveInterferenceSceneIcons.js @@ -1,9 +1,5 @@ // Copyright 2018, University of Colorado Boulder -//REVIEW very odd to have a class for this, especially since the icons are not at all related. Factory pattern would be -// better. -//REVIEW* They are all related in that they have commensurate dimensions, please see the last few lines -//REVIEW* of the constructor. What do you recommend? /** * Creates a set of uniformly-sized icons for each of the scenes. *