instrument ScoreDisplay* types

[pixelzoom]

ScoreboardBar appears at the top of many games, and looks like this:

In #66, ScoreboardBar was deprecated and replaced by FiniteStatusBar, to accommodate enhancement requests by designers.

One of the requests was to be able to use the new ScoreDisplay* types to display the score. The 4 ScoreDisplay* types were developed in #59 and #66, and they look like this:

The score display in ScoreboardBar was implemented and instrumented for PhET-iO like this:

94 // Score
95 var scoreText = new Text( '', _.extend( { tandem: options.tandem.createTandem( 'scoreText' ) }, textOptions ) );
96 scoreProperty.link( function( score ) {
97 scoreText.text = StringUtils.format( labelScoreString, score );
98 } );

Moving to FiniteStatusBar creates two issues for PhET-iO:

(1) None of the ScoreDisplay* types are currently instrumented for PhET-iO. So until they are instrumented, we've lost PhET-iO support for the score display in any games that used ScoreboardBar.

(2) Instances of ScoreDisplay* types are not created by FiniteStatusBar; they are created by the client and passed to FiniteStatusBar as a constructor argument. So if the structure is exposed in the phetioID (which it typically is) that structure is now totally different.

I have no plans to address this. Assigning to @samreid and @zepumph so that they are aware of this.

[pixelzoom]

@ariel-phet FYI.

[pixelzoom]

In case you were planning to dive right into this... Please hold off for a couple of hours, I'm making an API change that will make this a bit easier.

[pixelzoom]

API change completed. Status bars now create and manage their score display. So that makes this issue irrelevant:

(2) Instances of ScoreDisplay* types are not created by FiniteStatusBar; they are created by the client and passed to FiniteStatusBar as a constructor argument. So if the structure is exposed in the phetioID (which it typically is) that structure is now totally different.

[zepumph]

Currently the only game that is instrumented is BAA, and it will be largely reworked before republish. I don't plan on working on this until we are working on stable api for a sim with a game. Unassigning myself.

[samreid]

Understood--I suspect we will instrument these for the next stable PhET-iO game sim. Unassigning myself until then.