Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Best Time" was removed from level-selection buttons in several sims. #130

Closed
3 of 6 tasks
pixelzoom opened this issue Oct 29, 2024 · 3 comments
Closed
3 of 6 tasks

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 29, 2024

Over in phetsims/reactants-products-and-leftovers#95 (comment), QA identified that the "best time" no longer appears below the level-selection buttons in the Game screen. Further investigation revealed that "best time" was removed entirely from LevelSelectionButton in #120, and the commits therein indicate that the following sims have this regression:

First we test the above sims, and create sim-specific issues if they are indeed broken.

Second we should determine what the plan is for restoring this feature.

@pixelzoom
Copy link
Contributor Author

I've tested the sims that I'm responsible for, and they are broken. I created sim-specific GitHub issues, noted in the checklist above.

@KatieWoe or @Nancy-Salpepi would you have time to check the remaining sims in the checklist above? You can test in main. If they have this problem, please create a GitHub issue similar to phetsims/balancing-chemical-equations#163.

@github-project-automation github-project-automation bot moved this to Upcoming Tests (by priority) in QA Pipeline Oct 29, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Oct 29, 2024

@KatieWoe @Nancy-Salpepi — please hold off until @marlitas and I discuss. Re-reading #120 (where the work was done) it seems like there was a decision (in #120 (comment)) that we no longer need to display best time with the level-selection buttons. If that’s the case, and it’s OK only to display best time when a level is completed, than this may be a “won’t fix” issue.

@pixelzoom
Copy link
Contributor Author

According to #120 (comment), it was an intentional design decision, made by a quarum of designers and developers, to remove the "best time" display from LevelSelectionButton specifically and the level-selection user-interface in general. So closing this issue as "won't fix".

@github-project-automation github-project-automation bot moved this from Upcoming Tests (by priority) to Done in QA Pipeline Oct 29, 2024
@pixelzoom pixelzoom removed their assignment Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants