Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't step SpeechSynthesisAnnouncer if it is disabled? #76

Open
jessegreenberg opened this issue Apr 7, 2022 · 1 comment
Open

Don't step SpeechSynthesisAnnouncer if it is disabled? #76

jessegreenberg opened this issue Apr 7, 2022 · 1 comment
Assignees

Comments

@jessegreenberg
Copy link
Contributor

We might be doing unecessary operations when Voicing/SpeechSynthesis is not enabled by stepping in this case.

The UtteranceQueue returns in step if not enabled. Maybe we can/should do the same for SpeechSynthesisAnnouncer. The UtteranceQueue used to step the SpeechSynthesisAnnouncer, so this actually seems like a safe thing to do after we moved the announcer.step call out of the UTteranceQueue in #71.

@zepumph
Copy link
Member

zepumph commented Apr 7, 2022

Perhaps in addition to this, we should add a listener that applies to chromium wake engine workaround to speak an empty string right when we enable, so that it doesn't interfere with that on chromium.

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants