Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary common directory for model and view files #20

Closed
jessegreenberg opened this issue Aug 17, 2015 · 2 comments
Closed

Unnecessary common directory for model and view files #20

jessegreenberg opened this issue Aug 17, 2015 · 2 comments
Assignees
@dubson

Comments

@jessegreenberg
Copy link
Contributor

Noticed during code review, #14.

It is unconventional for PhET model and view files to share a common directory. The common directory usually holds elements for sims which are shared across multiple screens.

It looks like Util.js only has constants which are used in view files, so Util.js could be moved to trig-tour/view.
@jessegreenberg jessegreenberg mentioned this issue Aug 17, 2015
Closed
@dubson
Copy link
Contributor

dubson commented Aug 20, 2015

Agreed. Util.js moved to view folder.

@jessegreenberg
Copy link
Contributor Author

Closing since this was completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dubson dubson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dubson @jessegreenberg