Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity Force Lab - phet-io test #743

Closed
jbphet opened this issue Nov 29, 2016 · 4 comments
Closed

Gravity Force Lab - phet-io test #743

jbphet opened this issue Nov 29, 2016 · 4 comments

Comments

@jbphet
Copy link

jbphet commented Nov 29, 2016

Gravity Force Lab was just instrumented for phet-io. @samreid and I did a fair amount of testing as the work was being done, and now it would be good to have someone else make sure that we didn't miss or break anything.

Testing Matrix:
https://docs.google.com/spreadsheets/d/15Galf54GoI--GuRreo_p-hzIsZ7MlitRmiwc4dIUctg/edit#gid=2

EDIT: This should be tested from master. It should be verified with all working phet-io wrappers, and the instance-proxies in particular should be carefully checked.

Assigning to @ariel-phet for prioritization and assignment.

@jbphet
Copy link
Author

jbphet commented Nov 29, 2016

@phet-steele requested that the testing be done on a built version rather than from master, and I'm down with that, so I've built and deployed such a beast and it can be found at http://www.colorado.edu/physics/phet/dev/html/gravity-force-lab/2.1.0-phetiodev.1/.

@jbphet
Copy link
Author

jbphet commented Dec 14, 2016

The GitHub issue for instrumenting this sim is phetsims/gravity-force-lab#76. @phet-steele - if this testing is successful, please close the issue in the GFL repo. If not, assign it back to me.

@samreid
Copy link
Member

samreid commented Apr 3, 2017

I'm curious why testing was requested for a dev version instead of an RC version. Is this getting ready for production? Also, I recall gravity force lab was getting re-implemented as Coulomb's Lab was created. So it may need re-publication and testing on the newer version?

@ariel-phet
Copy link

This issue seems way stale and problematic, closing reassigning parent issue to @jbphet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants