Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All IO Type static functions should assert with a validator #167

Closed
zepumph opened this issue Apr 14, 2020 · 2 comments
Closed

All IO Type static functions should assert with a validator #167

zepumph opened this issue Apr 14, 2020 · 2 comments
Assignees
@chrisklus @zepumph
Labels
dev:phet-io priority:3-medium status:on-hold

Comments

@zepumph
Copy link
Member

zepumph commented Apr 14, 2020

From #163 (comment) @pixelzoom mentioned that many static IO Type functions like toStateObject and setValue that don't validate using this.validator.

We should make sure we are consistent. This means converting assert to use validate, and adding validate if it isn't there.
@samreid
Copy link
Member

samreid commented Sep 12, 2020

This will be addressed by the proposal in #211 which automatically validates. On hold until that issue is further along.

@samreid
Copy link
Member

samreid commented Sep 26, 2020

The project has been converted to use new IOType which automatically validates values in toStateObject and applyState. Closing.

@samreid samreid closed this as completed Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisklus chrisklus

@zepumph zepumph

Labels
dev:phet-io priority:3-medium status:on-hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samreid @chrisklus @zepumph