Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulate a plan for how to handle sound with LoL harness #57

Open
pixelzoom opened this issue Feb 5, 2019 · 6 comments
Open

formulate a plan for how to handle sound with LoL harness #57

pixelzoom opened this issue Feb 5, 2019 · 6 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Feb 5, 2019

There are at least 3 sim-specific issues reporting that sound doesn't stop playing when a sim is paused in the LoL harness:

https://github.com/phetsims/graphing-lines/issues/116
phetsims/fractions-common#80
phetsims/resistance-in-a-wire#194

phetsims/vibe#33 talks about porting sims from vibe to tambo.

tambo #51 talks about pausing sound playback while a sim is paused.

Labeling with meeting:developer to discuss. Assigning to @ariel-phet to prioritize, assign, and decided what to do about the sim-specific issues.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Feb 14, 2019

The LoL harness uses Sim.activeProperty to pause the sim. Could sound be linked to this Property? Then sound would stop in any wrapper using this Property, indluding PhET-iO wrappers.

@jessegreenberg
Copy link
Contributor

I see that soundManager already uses sim.activeProperty, so I am not sure why sound doesn't stop in the LoL harness.

@samreid
Copy link
Member

samreid commented Feb 14, 2019

That is not yet complete, see #51

@pixelzoom
Copy link
Contributor Author

@jessegreenberg said:

I see that soundManager already uses sim.activeProperty, I am not sure why sound doesn't stop in the LoL harness.

Two reasons:
(1) Some (most?) sims are still using vibe and need to be ported to tambo, see phetsims/vibe#33.
(2) tambo does not yet support pausing sound clips, see #51.

@ariel-phet
Copy link

@jbphet will investigate after phetsims/vibe#33 but maintenance releases are not necessary after this change.

@ariel-phet
Copy link

Marking as low priority since this work will not occur until things have been ported to tambo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants