-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formulate a plan for how to handle sound with LoL harness #57
Comments
The LoL harness uses Sim.activeProperty to pause the sim. Could sound be linked to this Property? Then sound would stop in any wrapper using this Property, indluding PhET-iO wrappers. |
I see that |
That is not yet complete, see #51 |
@jessegreenberg said:
Two reasons: |
@jbphet will investigate after phetsims/vibe#33 but maintenance releases are not necessary after this change. |
Marking as low priority since this work will not occur until things have been ported to tambo |
There are at least 3 sim-specific issues reporting that sound doesn't stop playing when a sim is paused in the LoL harness:
https://github.com/phetsims/graphing-lines/issues/116
phetsims/fractions-common#80
phetsims/resistance-in-a-wire#194
phetsims/vibe#33 talks about porting sims from vibe to tambo.
tambo #51 talks about pausing sound playback while a sim is paused.
Labeling with meeting:developer to discuss. Assigning to @ariel-phet to prioritize, assign, and decided what to do about the sim-specific issues.
The text was updated successfully, but these errors were encountered: