Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to set phetioIsVisiblePropertyInstrumented: false for the content of Checkbox and AquaRadioButton #784

Closed
pixelzoom opened this issue Aug 29, 2022 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Aug 29, 2022

How do we want to generally prevent PhET-iO clients from making the content of a Checkbox or AquaRadioButton invisible? We don't want to end up with just the box of a Checkbox, or just the circular button of an AquaRadioButton.

Currently, we have to add phetioIsVisiblePropertyInstrumented: false. And I find myself having to do this for every Checkbox and AquaRadioButton.

How do we make this more foolproof, or (even better) something developers don't have to deal with.

This also applies to VerticalCheckboxGroup and AquaRadioButtonGroup. Another option would be not to worry about this. Let clients hide these things, and come to their own conclusion that it doesn't make sense. That's a question for designers.

@pixelzoom
Copy link
Contributor Author

@samreid also wondered if we should set phetioReadOnly: true instead of phetioIsVisiblePropertyInstrumented: false. Again, a question for designers.

@zepumph zepumph changed the title How to set phetioIsVisiblePropertyInstrumented: false for Checkbox and AquaRadioButton How to set phetioIsVisiblePropertyInstrumented: false for the content of Checkbox and AquaRadioButton Sep 8, 2022
@zepumph
Copy link
Member

zepumph commented Sep 8, 2022

We discussed this in PhET-iO meeting, looking at NATURAL_SELECTION/WolvesCheckbox, and we feel like there is a good chance that most of this will be solved in phetsims/scenery#1447, where text Nodes won't get a visibleProperty by default.

The content for a checkbox/radioButtonGroup most often doesn't get instrumented unless it was a text (for string editability), so we will close this issue, and reopen if phetsims/scenery#1447 doesn't solve things.

@zepumph zepumph closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants