From 62254f0df854122c1b987147119003997dfad35e Mon Sep 17 00:00:00 2001 From: Michael Kauzmann Date: Fri, 7 Oct 2022 10:20:59 -0600 Subject: [PATCH] voicing and pdom visibility for modal dialogs should be handled in the same place in Sim, https://github.com/phetsims/ratio-and-proportion/issues/509 https://github.com/phetsims/joist/issues/293 --- js/Dialog.ts | 8 -------- 1 file changed, 8 deletions(-) diff --git a/js/Dialog.ts b/js/Dialog.ts index a251d3ed..96cc3fb8 100644 --- a/js/Dialog.ts +++ b/js/Dialog.ts @@ -364,11 +364,6 @@ export default class Dialog extends Popupable( Panel, 1 ) { // sound generation options.openedSoundPlayer.play(); - // pdom - modal dialogs should be the only readable content in the sim - // TODO: https://github.com/phetsims/joist/issues/293 non-modal dialogs shouldn't hide other accessible content, - // and this should be dependant on other things in the sim modalNodeStack - this.sim.setAccessibleViewsVisible( false ); - // Do this last options.showCallback && options.showCallback(); } @@ -376,9 +371,6 @@ export default class Dialog extends Popupable( Panel, 1 ) { // sound generation options.closedSoundPlayer.play(); - // pdom - when the dialog is hidden, make all ScreenView content visible to assistive technology - this.sim.setAccessibleViewsVisible( true ); - // Do this last options.hideCallback && options.hideCallback(); }