From 45571f3bd6150b69fd75e6cebd378d0cc2abcf16 Mon Sep 17 00:00:00 2001 From: Chris Malley Date: Thu, 17 Jan 2019 14:15:35 -0700 Subject: [PATCH] delete ComboBox.createItem, #450 Signed-off-by: Chris Malley --- js/ComboBox.js | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/js/ComboBox.js b/js/ComboBox.js index b278c974..1f04e96d 100644 --- a/js/ComboBox.js +++ b/js/ComboBox.js @@ -13,7 +13,6 @@ define( require => { // modules const ComboBoxButton = require( 'SUN/ComboBoxButton' ); const ComboBoxIO = require( 'SUN/ComboBoxIO' ); - const ComboBoxItem = require( 'SUN/ComboBoxItem' ); const ComboBoxListBox = require( 'SUN/ComboBoxListBox' ); const inherit = require( 'PHET_CORE/inherit' ); const InstanceRegistry = require( 'PHET_CORE/documentation/InstanceRegistry' ); @@ -213,7 +212,7 @@ define( require => { sun.register( 'ComboBox', ComboBox ); // Note: ComboBox cannot use ES6 class until its subtypes do - inherit( Node, ComboBox, { + return inherit( Node, ComboBox, { // @public - Provide dispose() on the prototype for ease of subclassing. dispose() { @@ -295,18 +294,4 @@ define( require => { } } } ); - - /** - * Creates a combo box item. Provided for backward compatibility. Using new ComboBoxItem is preferred. - * @param {Node} node - * @param {*} value - * @param {Object} [options] see ComboBoxItem - * @returns {ComboBoxItem} - * @public - */ - ComboBox.createItem = ( node, value, options ) => { - return new ComboBoxItem( node, value, options ); - }; - - return ComboBox; } ); \ No newline at end of file