Use event.code instead of event.key, see phetsims/scenery#1053

phetsims · Jun 23, 2021 · 3ee0c17 · 3ee0c17
1 parent 3a4784b
commit 3ee0c17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/js/accessibility/AccessibleNumberSpinner.js b/js/accessibility/AccessibleNumberSpinner.js
@@ -120,10 +120,10 @@ const AccessibleNumberSpinner = {
           },
           keyup: function( event ) {
 
-            const key = KeyboardUtils.getKeyDef( event.domEvent );
+            const key = KeyboardUtils.getEventCode( event.domEvent );
 
             if ( KeyboardUtils.isRangeKey( event.domEvent ) ) {
-              if ( runningTimerCallbackEvent && key === KeyboardUtils.getKeyDef( runningTimerCallbackEvent ) ) {
+              if ( runningTimerCallbackEvent && key === KeyboardUtils.getEventCode( runningTimerCallbackEvent ) ) {
                 self.emitKeyState( event.domEvent, false );
                 self._callbackTimer.stop( false );
                 self._callbackTimer.removeCallback( downCallback );

diff --git a/js/accessibility/AccessibleValueHandler.js b/js/accessibility/AccessibleValueHandler.js
@@ -290,7 +290,7 @@ const AccessibleValueHandler = {
         // block input event after handling the keydown event
         this.blockInput = false;
 
-        // @private {Object.<KeyDef, boolean>} - key is range key, value is whether it is down
+        // @private {Object.<string, boolean>} - key is the event.code for the range key, value is whether it is down
         this.rangeKeysDown = {};
 
         // @private - setting to enable/disable rounding to the step size
@@ -495,7 +495,7 @@ const AccessibleValueHandler = {
        */
       handleKeyDown( event ) {
         const domEvent = event.domEvent;
-        const key = KeyboardUtils.getKeyDef( domEvent );
+        const key = KeyboardUtils.getEventCode( domEvent );
         this._shiftKey = domEvent.shiftKey;
 
         // if we receive a keydown event, we shouldn't handle any input events (which should only be provided
@@ -604,15 +604,15 @@ const AccessibleValueHandler = {
        * @param {SceneryEvent} event
        */
       handleKeyUp( event ) {
-        const key = KeyboardUtils.getKeyDef( event.domEvent );
+        const key = KeyboardUtils.getEventCode( event.domEvent );
 
         // handle case where user tabbed to this input while an arrow key might have been held down
         if ( this.allKeysUp() ) {
           return;
         }
 
         // reset shift key flag when we release it
-        if ( key === KeyboardUtils.KEY_SHIFT ) {
+        if ( key === KeyboardUtils.KEY_SHIFT_LEFT ) {
           this._shiftKey = false;
         }