Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mirror inputs, "Return Atom" button becomes visible at different times #344

Open
phet-steele opened this issue Aug 19, 2020 · 4 comments
Open

Comments

@phet-steele
Copy link

In the Mirror Inputs wrapper of 1.2.0-rc.2

  1. Interaction screen
  2. Pause!
  3. Force the atoms together
  4. Hold down the step forward button, but start to be careful as the atom approaches the edge of the screen

You'll notice, by stepping slowly, that the "Return Atom" button appears on the bottom sim first:

image

Clicking in the top sim where the button would be will click the button in the bottom sim, leading to desynchronization.
Based on #325 (comment), I doubt this issue needs to be addressed before the delivery of 1.2,

Seen on Win 10 FF 80 For phetsims/qa/issues/531.

@arouinfar
Copy link
Contributor

Discussed with @jbphet and @kathy-phet. We decided that this does not block the 1.2.0 release. @jbphet will take a look at this to see if it's symptomatic of a larger problem.

@zepumph
Copy link
Member

zepumph commented Aug 21, 2020

I feel quite sure that this is the exact same problem as #325, since that was a general issue about Randoms getting out of sync. @phet-steele can you please confirm this is fixed on master. If this is the case, then cherry-picking changes for #325 will be enough, and this only needs to be confirmed fixed as a result of those changes.

@jbphet
Copy link
Contributor

jbphet commented Aug 21, 2020

Unassigning until the maintenance release is designated as one of my priorities.

@jbphet jbphet removed their assignment Aug 21, 2020
@phet-steele
Copy link
Author

I checked and doubled checked (by pulling repeatedly) that master on phettest had the changes listed in #325 (comment).

I, however, still see this issue on master.

@phet-steele phet-steele assigned zepumph and unassigned phet-steele Aug 24, 2020
@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants