comboBox's enableProperty is not respected when displayOnlyProperty is altered

[phet-steele]

In the Studio wrapper of 1.2.0-rc.2:

1. Find statesOfMatter.statesScreen.view.particleContainerNode.compositeThermometerNode.temperatureComboBox.enabledProperty and disable the combo box.
2. Find statesOfMatter.statesScreen.view.particleContainerNode.compositeThermometerNode.temperatureComboBox.displayOnlyProperty (just above enabledProperty) and toggle it twice, on then off.

You should now be able to interact with the combo box in the sim, even though enabledProperty is false. I'm sure this is going to be a general issue for a common code repository.

IMPORTANT NOTE: This issue seems to resolve itself after the sim is launched with customization. In other words, I'm only seeing this happen in the wrapper itself.

Seen on Win 10 FF 80 For phetsims/qa/issues/531 and phetsims/qa/issues/532.

[jbphet]

I think it's safe to say that this is not blocking for the 1.2.0 release.

[kathy-phet]

@jbphet @arouinfar @kathy-phet - Definitely not blocking for SOM. Probably a small @pixelzoom fix, since he has been working on combo boxes most.

@pixelzoom - This impacts pH Scale, also. It's not critical because its not a realistic customization. We are OK deferring this fix, but if its quick and you want to fix it, then go ahead.

[zepumph]

@pixelzoom, in addition, if this effects ph-scale, please make an issue in that repo to make sure it ends up in that RC shas.

[pixelzoom]

I'm not at all familiar with this issue.

@arouinfar if this problem is present in ph-scale 1.4.0-rc.1 or ph-scale-basics 1.4.0-rc.1 and needs to be addressed, either in the next RC or in a subsequent maintenance release, then please create a parallel issue (with same title as this issue, and referencing this issue) in ph-scale. Note when the issue needs to be addressed.

@pixelzoom EDIT: Tracking for ph-scale in phetsims/ph-scale#204.

[pixelzoom]

Btw... I lost track of this issue because it lives in SOM. Highly recommended to transfer general issues like this to their relevant repo - in this case, studio. Then create sim-specific issues in repos where the general issue needs to be addressed.

[pixelzoom]

@jbphet I do not see this issue in master or the published version at https://phet-dev.colorado.edu/html/states-of-matter/1.2.0/phet-io/wrappers/studio/. Did someone fix it, or did it self heal?

[pixelzoom]

Oh wait. I do see it. The combo box still looks disabled, but you can interact with it (I misunderstood that bit). I've located the source of the problem, and created phetsims/sun#617.

[arouinfar]

While the behavior is buggy, it's the result of unrealistic customization. It is not RC-blocking, and I don't think it's serious enough to include in the maintenance release currently planned for SOM.

I think we can probably close this issue, but I'll let @jbphet decide if he wants to keep it open while the sun issue is unresolved.

[jbphet]

I'm happy to close, since I agree that it's the result of an unrealistic customization.