Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio molecules in scene buttons shift when text disappears #298

Closed
KatieWoe opened this issue Jun 19, 2020 · 4 comments
Closed

Studio molecules in scene buttons shift when text disappears #298

KatieWoe opened this issue Jun 19, 2020 · 4 comments
Assignees
Labels

Comments

@KatieWoe
Copy link
Contributor

For phetsims/qa#508, but seems to be SOM rather than studio.
When using the visible property to remove the text that is on the buttons to change scenes, the molecule image shifts a bit when the text disappears.
shiftingmolecule

@jbphet
Copy link
Contributor

jbphet commented Jun 22, 2020

@arouinfar - please weigh in and let me know if you think this is something that should be addressed and, if so, if it is blocking for the initial dev release to the customer.

@arouinfar
Copy link
Contributor

@jbphet this is not critical to fix for the initial dev release. I wonder if this could be related to the dynamic layout when UI elements are removed. If I change the textProperty of the string to null, the layout is undisturbed.
image

@arouinfar arouinfar removed their assignment Jun 23, 2020
@arouinfar
Copy link
Contributor

Actually, on second thought, I think the current behavior is fine.

The gif shows what happens when the visibleProperty of the string (e.g. argonText) is set to false. This is not featured, and there are other ways to hide this text. If the goal is to remove the entire radio button, then the visibleProperty of the radio button should be set to false. If the goal is to hide the name, its textProperty can be edited to be a null string. Neither of these methods cause layout issues.

@jbphet please feel free to close if you agree.

@jbphet
Copy link
Contributor

jbphet commented Jun 23, 2020

Thanks. I do agree. Closing.

@jbphet jbphet closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants