Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grunt create-sim should not always add phet-io dependencies #29

Open
samreid opened this issue Oct 15, 2024 · 3 comments
Open

grunt create-sim should not always add phet-io dependencies #29

samreid opened this issue Oct 15, 2024 · 3 comments

Comments

@samreid
Copy link
Member

samreid commented Oct 15, 2024

For instance, for open source clients, we will not want to have the phet-io repos in the dependencies. That affects tasks like grunt checkout-main.

@samreid samreid self-assigned this Oct 15, 2024
@zepumph
Copy link
Member

zepumph commented Oct 15, 2024

This may be a similar part of discussion in #30. I feel like we need a flag in create-sim as to whether or not the sim is being create for phet or sceneryStack. This could include the change to the copyright lint rule.

@samreid
Copy link
Member Author

samreid commented Oct 17, 2024

~/.phet/build-local.json as accessed in buildLocal.js already has a section for brands, which defaults to ['adapted-from-phet']. Should we use that?

@zepumph
Copy link
Member

zepumph commented Nov 21, 2024

Unassigning until we work on this for POSE2 (actually using the flag).

@zepumph zepumph removed their assignment Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants