Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dag related tests for aria-labelledby associations #821

Open
Tracked by #953
zepumph opened this issue Jun 28, 2018 · 4 comments
Open
Tracked by #953

Add more dag related tests for aria-labelledby associations #821

zepumph opened this issue Jun 28, 2018 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jun 28, 2018

We are testing dag pretty well one just 1 case (when you are labelledby yourself).

@zepumph zepumph self-assigned this Jun 28, 2018
@zepumph
Copy link
Member Author

zepumph commented Jul 4, 2018

@jessegreenberg could you help me out with this one? Or maybe could we do it together?

@zepumph
Copy link
Member Author

zepumph commented Jul 24, 2018

I thought about one more test that would be nice here, relating to having accessible content or not.


    var m = new Node();
    var n = new Node( {tagName: 'div' });
    m[ addAssociationFunction ]( {
      otherNode: n,
      thisElementName: AccessiblePeer.PRIMARY_SIBLING,
      otherElementName: AccessiblePeer.LABEL_SIBLING
    } );
    
    m.tagName = 'div';
    /* test */

    var m = new Node();
    var n = new Node();
    m[ addAssociationFunction ]( {
      otherNode: n,
      thisElementName: AccessiblePeer.PRIMARY_SIBLING,
      otherElementName: AccessiblePeer.LABEL_SIBLING
    } );

    m.tagName = 'div';
    n.tagName = 'div';
    /* test */

@jessegreenberg
Copy link
Contributor

Good idea @zepumph. In a dev meeting a while ago, we added more tests to verify behavior after other changes to the scene graph such as adding/removing children, reordering children, and more than one association. I also took a look at the way describedby is being tested in the same way, it looks very nice. Removing my assignment for now, but feel free to reassign if you wish.

@jessegreenberg jessegreenberg removed their assignment Jul 24, 2018
@zepumph
Copy link
Member Author

zepumph commented Sep 1, 2018

  • Another test that would be good would be to add the same object twice. I think that we should detect this and throw an error. What do you think @jessegreenberg?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants