Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review ariaLabel getter/setter in new A11y API #751

Closed
zepumph opened this issue Mar 26, 2018 · 1 comment
Closed

Review ariaLabel getter/setter in new A11y API #751

zepumph opened this issue Mar 26, 2018 · 1 comment
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Mar 26, 2018

@jessegreenberg, I think it would be best to review individual pieces of the a11y api change. Just to be sure we don't miss anything. Please review all the commits above #748 (comment) regarding the ariaLabel attribute change from boolean to string.
@jessegreenberg
Copy link
Contributor

Changes look good @zepumph. Thanks for adding tests. Reviewing changes only verified that this was the right decision. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph