Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should SimpleDragHandler.dragListener cancel on reset? #487

Closed
jessegreenberg opened this issue Oct 28, 2015 · 1 comment
Closed

Should SimpleDragHandler.dragListener cancel on reset? #487

jessegreenberg opened this issue Oct 28, 2015 · 1 comment
Assignees

Comments

@jessegreenberg
Copy link
Contributor

The issue was first discovered in a dev test of phetsims/charges-and-fields#20. After pressing the reset button, the drag listener in SimpleDragHandler is not canceled. For multi-touch, this creates an issue where the dragged item will snap to the pointer if the pointer does not release after 'reset' is called. For instance, to reproduce with the HSlider thumb:

  1. Drag the thumb to any position and hold.
  2. Press 'Reset All' with another finger without lifting the first pointer.
  3. Move the first pointer, the thumb of the slider will snap to the position of the original pointer.

I wanted to create an issue for this, but I am not sure that this is worth pursuing. If the user presses reset without lifting the pointer, they would expect the node to snap to the maintained pointer position.

@jonathanolson, are you aware of this behavior or do you think it should be fixed in SimpleDragHandler?

@jessegreenberg
Copy link
Contributor Author

@jonathanolson just pointed me to an open issue #218 which this seems to be a duplicate of. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants