Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PressListener's click() can call press without an event #1353

Open
jonathanolson opened this issue Feb 9, 2022 · 1 comment
Open

PressListener's click() can call press without an event #1353

jonathanolson opened this issue Feb 9, 2022 · 1 comment
Assignees
Labels

Comments

@jonathanolson
Copy link
Contributor

Discovered in phetsims/phet-core#103, the pressListener call in click() breaks the typing we've established. I'd like to discuss with @jessegreenberg how to handle, since our system may be more resilient to null events on presses than I anticipated.

@jessegreenberg
Copy link
Contributor

We are currently relying on the ability to call PressListener.click() externally without an event in a couple of places. Perhaps we can revisit those cases if the PressListenerCallback requires an event. Or maybe we can create a fake SceneryEvent to pass through in those use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants