Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText linkEventsHandled is broken #1352

Open
jonathanolson opened this issue Feb 9, 2022 · 0 comments
Open

RichText linkEventsHandled is broken #1352

jonathanolson opened this issue Feb 9, 2022 · 0 comments
Assignees
Labels

Comments

@jonathanolson
Copy link
Contributor

It will never call handle(), and it's been this way for a while. I'll need to investigate the best and safest way to fix this. Discovered in phetsims/phet-core#103 (yay TypeScript)

The bug is:

self._linkEventsHandled && event.handle();

where self refers to window.self (and it's not even in RichText, so it's hard to forward that info over).

@jonathanolson jonathanolson self-assigned this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant