Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ReadingBlockHitShape back into Voicing #1212

Closed
jessegreenberg opened this issue Apr 27, 2021 · 1 comment
Closed

Move ReadingBlockHitShape back into Voicing #1212

jessegreenberg opened this issue Apr 27, 2021 · 1 comment
Assignees

Comments

@jessegreenberg
Copy link
Contributor

I had thought that the readingBlockHitShape property of ReadingBlock was specific to ReadingBlocks, but it is needed for other things that mix Voicing. It should be moved back into Voicing, and work for both ReadingBlock highlights and Interactive Highlights.

This is needed of Voicing work going on now in RaP, with AccordionBox.

@jessegreenberg
Copy link
Contributor Author

This was done as part of #1217, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant